Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actions URL in commit status webhooks absolute #33620

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 17, 2025

Gitea Actions generated target url doesn't contain host and port. So we need to include them for external webhook visiting.

Fix #33603

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Feb 17, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 17, 2025
@lunny lunny mentioned this pull request Feb 17, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2025
@delvh delvh changed the title Fix webhook target url generated by actions status event Make actions URL in commit status webhooks absolute Feb 17, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2025
@wxiaoguang wxiaoguang marked this pull request as draft February 17, 2025 09:27
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review February 18, 2025 01:54
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 18, 2025 01:58
@wxiaoguang wxiaoguang merged commit 9f560d4 into go-gitea:main Feb 18, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 18, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 18, 2025
Gitea Actions generated target url doesn't contain host and port. So we
need to include them for external webhook visiting.

Fix go-gitea#33603

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 18, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 18, 2025
* giteaofficial/main:
  Make actions URL in commit status webhooks absolute (go-gitea#33620)
  Refactor error system (go-gitea#33626)
  Move issue pin to an standalone table for querying performance (go-gitea#33452)
  Run spellcheck on tools directory (go-gitea#33627)
  Refactor error system (go-gitea#33610)
  Fix project issues list and counting (go-gitea#33594)
wxiaoguang added a commit that referenced this pull request Feb 18, 2025
Backport #33620 by lunny

Fix #33603

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny deleted the lunny/fix_status_webhook_target_url branch February 18, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord "Commit Status" Webhooks Are Broken
5 participants