Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve English grammar and consistency #3614

Merged
merged 25 commits into from
Apr 19, 2018
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
94618f7
Start improving English grammar and consistency.
bugreport0 Mar 2, 2018
4322fa7
Apply review comments, push translation further.
bugreport0 Mar 5, 2018
b459740
Merge branch 'master' into patch-6
bugreport0 Mar 5, 2018
22f651e
Additional review changes; expand translation.
bugreport0 Mar 6, 2018
6e5e751
Merge branch 'master' into patch-6
bugreport0 Mar 6, 2018
6f34061
Undo team/organization change, further translation.
bugreport0 Mar 11, 2018
5365e23
Merge branch 'master' into patch-6
bugreport0 Mar 11, 2018
9c4a89a
Add site administration; review comments; merge.
bugreport0 Mar 15, 2018
53e8eaf
Merge branch 'master' into patch-6
bugreport0 Mar 15, 2018
83811aa
Merge branch 'master' into patch-6
bugreport0 Mar 18, 2018
2e0850d
Merge branch 'master' into patch-6
bugreport0 Mar 18, 2018
3d69edb
Update hardcoded branch protection string tests.
bugreport0 Mar 19, 2018
0d1c394
Update hardcoded branch deletion string test.
bugreport0 Mar 19, 2018
85363da
Merge branch 'master' into patch-6
bugreport0 Mar 19, 2018
c3333b8
Update another hardcoded translation string test.
bugreport0 Mar 19, 2018
407ae76
Add my nickname to the list of translators.
bugreport0 Mar 19, 2018
78405b2
Implement @lafriks review comments.
bugreport0 Mar 29, 2018
c166d27
Merge branch 'master' into patch-6
bugreport0 Mar 29, 2018
d6a6af4
Merge branch 'master' into patch-6
bugreport0 Mar 29, 2018
93da6de
Remove (now) unused branch deletion warnings.
bugreport0 Mar 29, 2018
368a2cc
Remove (now) unused branch deletion warnings.
bugreport0 Mar 29, 2018
25cee9d
Merge branch 'master' into patch-6
lunny Mar 29, 2018
ee4721c
Merge branch 'master' into patch-6
bugreport0 Apr 17, 2018
87d89a1
Merge branch 'master' into patch-6
lafriks Apr 19, 2018
f20fdf9
Merge branch 'master' into patch-6
appleboy Apr 19, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions integrations/editor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func TestCreateFileOnProtectedBranch(t *testing.T) {
// Check if master branch has been locked successfully
flashCookie := session.GetCookie("macaron_flash")
assert.NotNil(t, flashCookie)
assert.EqualValues(t, "success%3DBranch%2Bmaster%2Bprotect%2Boptions%2Bchanged%2Bsuccessfully.", flashCookie.Value)
assert.EqualValues(t, "success%3DBranch%2Bprotection%2Bfor%2Bbranch%2B%2527master%2527%2Bhas%2Bbeen%2Bupdated.", flashCookie.Value)

// Request editor page
req = NewRequest(t, "GET", "/user2/repo1/_new/master/")
Expand All @@ -73,7 +73,7 @@ func TestCreateFileOnProtectedBranch(t *testing.T) {

resp = session.MakeRequest(t, req, http.StatusOK)
// Check body for error message
assert.Contains(t, resp.Body.String(), "Can not commit to protected branch 'master'.")
assert.Contains(t, resp.Body.String(), "Cannot commit to protected branch 'master'.")

// remove the protected branch
csrf = GetCSRF(t, session, "/user2/repo1/settings/branches")
Expand All @@ -86,7 +86,7 @@ func TestCreateFileOnProtectedBranch(t *testing.T) {
// Check if master branch has been locked successfully
flashCookie = session.GetCookie("macaron_flash")
assert.NotNil(t, flashCookie)
assert.EqualValues(t, "success%3DBranch%2Bmaster%2Bprotect%2Boptions%2Bremoved%2Bsuccessfully", flashCookie.Value)
assert.EqualValues(t, "success%3DBranch%2Bprotection%2Bfor%2Bbranch%2B%2527master%2527%2Bhas%2Bbeen%2Bdisabled.", flashCookie.Value)

}

Expand Down
2 changes: 1 addition & 1 deletion integrations/pull_merge_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,5 @@ func TestPullCleanUpAfterMerge(t *testing.T) {
htmlDoc := NewHTMLParser(t, resp.Body)
resultMsg := htmlDoc.doc.Find(".ui.message>p").Text()

assert.EqualValues(t, "user1/feature/test has been deleted.", resultMsg)
assert.EqualValues(t, "Branch 'user1/feature/test' has been deleted.", resultMsg)
}
1 change: 1 addition & 0 deletions options/locale/TRANSLATORS
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Antoine GIRARD <sapk AT sapk DOT fr>
Arthur Aslanyan <arthur DOT e DOT aslanyan AT gmail DOT com>
Aurelien Darragon <aurelien DOT darragon AT gmail DOT com>
Barış Arda Yılmaz <ardayilmazgamer AT gmail DOT com>
bugreport0
Camille Baronnet <gogs AT camillebaronnet DOT fr>
Christoph Kisfeld <christoph DOT kisfeld AT gmail DOT com>
Cysioland
Expand Down
Loading