Some updates to installation texts #3623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
==========================================
+ Coverage 36.14% 36.14% +<.01%
==========================================
Files 285 285
Lines 40925 40925
==========================================
+ Hits 14791 14792 +1
Misses 23959 23959
+ Partials 2175 2174 -1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
options/locale/locale_en-US.ini
Outdated
| http_port = HTTP Port | ||
| http_port_helper = Port number which application will listen on. | ||
| http_port = Local HTTP Port | ||
| http_port_helper = The port on which gitea serves the API in its execution context (e.g. a container). |
There was a problem hiding this comment.
It's not only API but all http requests, so instead of API it would probably be web
There was a problem hiding this comment.
maybe there's a misunderstand, what is this value used for other than calls to the api by igitea itself? at least that was my conclusion when i realised i just had to leave it as 3000 when running from the provided Docker image while that port is mapped to another one externally.
There was a problem hiding this comment.
It is the port gitea web will listen on for web/API/git http requests (localy) and http proxy in front needs to forward requests to this port if used.
There was a problem hiding this comment.
There should be space between web and interface
tboerger
added
lgtm/need 1
tboerger
added
lgtm/done
i did this mainly because the help text `http_port_helper` was rather confusing as i didn't enter (or rather leave) the proper value there in a Docker setup, resulting in a hard-to-troubleshoot installation. twice in the meantime. otherwise i tried to improve the style and consistency.
|
|
|
@funkyfuture sorry for asking for one more change but first |
|
why should it? i'm not an english native speaker, but another have western germanic language as mother tongue. and to use a possesive pronoun is just appropriate in this context. |
|
But it is not good style to repeat words in same sentence and first one is not really that needed anyway, it just sounds weird :) |
|
I've been working on the translation in #3614 … comments welcome. |
|
oh shit, sorry, i haven't seen this. i'm fine if you consider and incorprate what i proposed here. i give the install part a review then. deal? |
|
@funkyfuture Yes, please review and see if I already solved your issue. Comments welcome. I just want to keep all English translation improvements in one place until we can merge them. |
|
closing this in favor of #3614. |
i did this mainly because the help text
http_port_helperwas rather confusingas i didn't enter (or rather leave) the proper value there in a Docker setup,
resulting in a hard-to-troubleshoot installation. twice in the meantime.
otherwise i tried to improve the style and consistency.