Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Update issues via pull requests #3695

Closed
wants to merge 32 commits into from
Closed

[RFC] Update issues via pull requests #3695

wants to merge 32 commits into from

Commits on Dec 11, 2018

  1. Update issues when a pull request is merged

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d6ff201 View commit details
    Browse the repository at this point in the history

  2. Factor out detection of reference, close, reopen keywords into a more… 

    … reusable function
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    224f0fd View commit details
    Browse the repository at this point in the history

  3. Only change issue status when commits have been merged

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d418d92 View commit details
    Browse the repository at this point in the history

  4. Add issue updating from commit messages in new pull request

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    06fcda9 View commit details
    Browse the repository at this point in the history

  5. Clean up {Merge,New}PullRequestAction and add UpdatePullRequestAction

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    c1dac9c View commit details
    Browse the repository at this point in the history

  6. Add issue updating from commits being tracked by pull requests

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    32c9209 View commit details
    Browse the repository at this point in the history

  7. Fix code formatting

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    bb65b7f View commit details
    Browse the repository at this point in the history

  8. Rename {Update -> Commit}PullRequestAction to be more accurately named

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    cd17446 View commit details
    Browse the repository at this point in the history

  9. Factor out creation of reference comments

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d9ea596 View commit details
    Browse the repository at this point in the history

  10. Add the UpdateIssuesComment function 

    The UpdateIssuesComment function handles referencing and manipulation of
issues from comments, issues, and pull requests
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    29dacbd View commit details
    Browse the repository at this point in the history

  11. Hook up the UpdateIssuesComment function to various actions 

    The UpdateIssuesComment function is now being called when:
- a pull request is merged, so the pull request title or description can
open/close issues
- a new pull request is created, so it can reference an issue from its
title or description
- a new issue is created, so it can reference an issue from its title or
description
- a pull request or issue title or description is updated
- a comment is created or updated, so it can reference an issue from its
title or description
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ff00d31 View commit details
    Browse the repository at this point in the history

  12. Add the LoadReference function 

    Add the LoadReference function to prepare data members of reference
types of comments for frontend rendering.  Also prepares for the
transition of commit reference comments into a new message format.
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    83d08c2 View commit details
    Browse the repository at this point in the history

  13. Hook up frontend templates to render reference comments 

    Commit features:
- renders reference comments only if their source still exists (except
for old style commit refs)
- allows for more complex rendering options, e.g. issue or commit
status, quoted comments, etc.
- properly handles updates to issue/PR titles, movement of repositories,
etc.

NOTE:  Only the en_US locale is provided by this commit.
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ce0333f View commit details
    Browse the repository at this point in the history

  14. Change commit ref comments to use a more parse-able form of content

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    c6a7ce5 View commit details
    Browse the repository at this point in the history

  15. Applied suggested code changes 

    * better commented KeywordsFound bitmask constants
* populate issueKeywordsToFind variable at point of definition rather
than in init()
* add needed `xorm:"-"` statements to the fields that were added to
Comment
* also move calculation of uniqueID out of loop
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    3d72103 View commit details
    Browse the repository at this point in the history

  16. Improve code coverage of TestUpdateIssuesCommit

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    cf174ea View commit details
    Browse the repository at this point in the history

  17. Add test for referencing issues in comments

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    943be3d View commit details
    Browse the repository at this point in the history

  18. Add test for updating issues from issues

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    9f5b9ea View commit details
    Browse the repository at this point in the history

  19. Update TestCreateComment to check referenced issue

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    98e12ce View commit details
    Browse the repository at this point in the history

  20. Correct error message

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    af7c75b View commit details
    Browse the repository at this point in the history

  21. Trigger MergePullRequestAction when PR is manually merged

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    8454950 View commit details
    Browse the repository at this point in the history

  22. Change variable names from KeywordsFound* to Keyword*

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    5e48595 View commit details
    Browse the repository at this point in the history

  23. Move common status changing logic into a function

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    7c8204a View commit details
    Browse the repository at this point in the history

  24. Change "x := int64(0)" statements to "var x int64"

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    1768f33 View commit details
    Browse the repository at this point in the history

  25. Refactor reference comment related code 

    - Move all code related to getting/setting the uniqueness SHA identifier
of a reference comment into issue_comment.go
- Prepare the reference comment code to handle references to issues in
other repos
- Clean up redundant and confusing code, remove use of deprecated
ShortSHA function
- Consistent formatting for issue-linking comments
    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    a398702 View commit details
    Browse the repository at this point in the history

  26. Update issue referencing comment tests

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    65efac5 View commit details
    Browse the repository at this point in the history

  27. Push pull request commits to base before trying to use them

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    0da2736 View commit details
    Browse the repository at this point in the history

  28. Don't exit early in NewPullRequest

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    05c4691 View commit details
    Browse the repository at this point in the history

  29. Complete addition of code comments and review issue referencing comments

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    18e63c1 View commit details
    Browse the repository at this point in the history

  30. Fix to only get commits along head branch

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ee360eb View commit details
    Browse the repository at this point in the history

  31. Code cleanup

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    7e2fbdb View commit details
    Browse the repository at this point in the history

  32. Add reformatAndAddReferenceComments migration v75

    @krrutkow
    krrutkow committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ac30d94 View commit details
    Browse the repository at this point in the history