Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code tab link when viewing tags #3908

Merged
merged 1 commit into from
May 7, 2018
Merged

Fix code tab link when viewing tags #3908

merged 1 commit into from
May 7, 2018

Conversation

serverwentdown
Copy link
Contributor

"Code" tab button in the repo view assumes that the current BranchName is always a branch. This fix replaces the hardcoded "branch/{{.BranchName}}" path with the proper "{{.BranchNameSubURL}}".

Signed-off-by: Ambrose Chua <ambrose@chua.family>
@codecov-io
Copy link

Codecov Report

Merging #3908 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3908   +/-   ##
=======================================
  Coverage   20.16%   20.16%           
=======================================
  Files         145      145           
  Lines       29171    29171           
=======================================
  Hits         5881     5881           
  Misses      22395    22395           
  Partials      895      895

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04889b7...bcbe60c. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 7, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2018
@appleboy appleboy merged commit 3a6f3c8 into go-gitea:master May 7, 2018
johnrazeur pushed a commit to johnrazeur/gitea that referenced this pull request Jun 17, 2018
Signed-off-by: Ambrose Chua <ambrose@chua.family>
daviian pushed a commit that referenced this pull request Jun 17, 2018
Signed-off-by: Ambrose Chua <ambrose@chua.family>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants