add missing token validation and missing alert in UI #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3976 +/- ##
=========================================
Coverage ? 20.08%
=========================================
Files ? 146
Lines ? 29867
Branches ? 0
=========================================
Hits ? 6000
Misses ? 22961
Partials ? 906Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
approved these changes
May 16, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
May 16, 2018
bkcsoft
added
lgtm/done
|
@daviian please send back port to release/v1.4 |
daviian
added a commit
to daviian/gitea
that referenced
this pull request
May 16, 2018
lunny
pushed a commit
that referenced
this pull request
May 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Should be backported to
release/v1.4