Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete comment bug #4216

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Fix delete comment bug #4216

merged 2 commits into from
Jun 11, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 11, 2018

will fix #4210

@lunny lunny added this to the 1.5.0 milestone Jun 11, 2018
@codecov-io
Copy link

codecov-io commented Jun 11, 2018 •
edited
Loading

Codecov Report

Merging #4216 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4216      +/-   ##
==========================================
+ Coverage   19.96%   19.96%   +<.01%     
==========================================
  Files         153      153              
  Lines       30498    30501       +3     
==========================================
+ Hits         6088     6091       +3     
- Misses      23495    23496       +1     
+ Partials      915      914       -1
Impacted Files Coverage Δ
models/issue_comment.go 27.06% <0%> (-0.16%) ⬇️
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508092a...ebd05fe. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2018
@techknowlogick techknowlogick merged commit da898d4 into go-gitea:master Jun 11, 2018
@techknowlogick
Copy link
Member

@lunny This has now been merged. Please send backport.

@lunny lunny deleted the lunny/fix_delete_comments branch June 12, 2018 01:28
lunny added a commit to lunny/gitea that referenced this pull request Jun 12, 2018
@lunny
fix delete comment bug (go-gitea#4216)
d386d83
@lunny lunny mentioned this pull request Jun 12, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 12, 2018
lafriks pushed a commit that referenced this pull request Jun 12, 2018
@lunny @lafriks
fix delete comment bug (#4216) (#4228)
f106404
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Critical bug: Attachments were accidentally deleted
7 participants
@lunny @codecov-io @techknowlogick @lafriks @jonasfranz @Bwko @bkcsoft