Fix open redirect vulnerability on login screen #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Codecov Report
@@ Coverage Diff @@
## master #4312 +/- ##
=========================================
+ Coverage 20.09% 20.1% +0.01%
=========================================
Files 153 153
Lines 30696 30705 +9
=========================================
+ Hits 6168 6174 +6
- Misses 23586 23588 +2
- Partials 942 943 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
reviewed
Jun 25, 2018
| newTest(true, | ||
| "http://example.com"), | ||
| newTest(false, | ||
| "a/"), |
There was a problem hiding this comment.
Because it is not external
| "a/"), | ||
| newTest(false, | ||
| "https://try.gitea.io/test?param=false"), | ||
| newTest(false, |
There was a problem hiding this comment.
Because it is not external
| "test?param=false"), | ||
| newTest(false, | ||
| "//try.gitea.io/test?param=false"), | ||
| newTest(false, |
There was a problem hiding this comment.
Because it is not external
techknowlogick
added
the
topic/security
techknowlogick
approved these changes
Jun 25, 2018
bkcsoft
added
lgtm/need 1
|
LGTM |
bkcsoft
added
lgtm/done
|
@JonasFranzDEV could you backport this to 1.4 as well? |
|
I'm working on a backport to 1.4 |
Merged
7 tasks
sapk
reviewed
Jun 28, 2018
| if err != nil { | ||
| return true | ||
| } | ||
| if len(parsed.Host) != 0 && strings.Replace(parsed.Host, "www.", "", 1) != strings.Replace(setting.Domain, "www.", "", 1) { |
ghost
mentioned this pull request
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4307 by checking if URL is external before redirecting.
Affected: