Automatically clear stopwatch on merging a PR

[adelowo]

Whenever a timer is created, it should be closed automatically whenever the PR is merged and/or an issue/PR is closed as per #4327 (comment) . This PR adds that functionality .

This uses ctx.Flash to show a one time message that the timer would be closed automatically as per #4327 (comment)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@5bd594c). Click here to learn what that means.
The diff coverage is 51.51%.

@@            Coverage Diff            @@
##             master    #4327   +/-   ##
=========================================
  Coverage          ?   38.71%           
=========================================
  Files             ?      330           
  Lines             ?    48623           
  Branches          ?        0           
=========================================
  Hits              ?    18822           
  Misses            ?    27075           
  Partials          ?     2726

Impacted Files	Coverage Δ
routers/repo/issue_stopwatch.go	42.1% <100%> (ø)
routers/repo/issue.go	36.56% <20%> (ø)
routers/repo/pull.go	34.14% <27.27%> (ø)
models/action.go	60.98% <55.55%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd594c...0ccd672. Read the comment docs.

[jonasfranz]

I think that it might be a little bit confusing if you stop a stopwatch without telling the user. I would propose to add a hint to the UI to indicate that the stopwatch will be stopped.

[adelowo]

Hi @JonasFranzDEV , where should that go in.. UI related things aren't what I would consider easy but could use some direction..

BTW, I was actually thinking it could more of a repo/global setting ???

[jonasfranz]

@adelowo Just a hint at the submit button with the info that it will stop the stopwatch.

[lafriks]

Wouldn't it be better in issue closing function. This way it would stop timer when closing issue or PR and also when merging I think

[adelowo]

Nice one @lafriks ... I would try that out

@JonasFranzDEV Would do just that

[adelowo]

Would update this PR over the weekend

[bkcsoft]

@JonasFranzDEV I think we could use ctx.Flash for this 🤔

[adelowo]

Hi @lafriks , i tried that but merging a PR didn't trigger this when I placed it in the issue closing function.. I was able to do it some other way though .

[adelowo]

This is ready to be reviewed anyways ....

[jonasfranz]

Timer gets stopped if I reopen an issue. The message will be shown too if an issue is closed.

[adelowo]

@JonasFranzDEV do you mean the timer starts again when the issue is reopened ? That doesn't happen

The message will be shown too if an issue is closed

No, the message isn't shown when the issue ( timer ) is closed (stopped)

[techknowlogick]

@jonasfranz please review

[adelowo]

Can this be reviewed please ?

This review was related to translation file which has been updated with suggestion.