Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoints for stars #46

Closed
wants to merge 1 commit into from
Closed

API endpoints for stars #46

wants to merge 1 commit into from

Conversation

DblK
Copy link
Member

@DblK DblK commented Nov 3, 2016

Migration of Gogs PR #3815

@DblK
Copy link
Member Author

DblK commented Nov 3, 2016

@ethantkoenig can you submit your PR here instead of on Gogs original repo?

@codecov-io
Copy link

Current coverage is 2.18% (diff: 0.00%)

Merging #46 into master will decrease coverage by <.01%

@@            master       #46   diff @@
========================================
  Files           31        31          
  Lines         7508      7522    +14   
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
- Misses        7327      7341    +14   
  Partials        17        17          

Powered by Codecov. Last update 42a744d...7f31187

@ethantkoenig
Copy link
Member

Hi @DblK, I appreicate the response to my PR. However, I would like for this PR to eventually get merged into gogits/gogs. Are you planning to merge the changes on gitea into gogits/gogs at some point? What is the point of gitea?

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

The author of Gogs is not responding again and he keeps rejecting more people with write rights, so we resurrected this fork to push development by multiple people forward.

@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use cherry-pick to take the original author commits.

@tboerger tboerger added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Nov 3, 2016
@strk strk modified the milestones: 1.1.0, 1.0.0 Nov 6, 2016
@ethantkoenig
Copy link
Member

ethantkoenig commented Nov 6, 2016

In response to @tboerger's request, I have opened a new PR: #100.

@lunny
Copy link
Member

lunny commented Nov 7, 2016

Then close this one.

@lunny lunny closed this Nov 7, 2016
@lunny lunny removed this from the 1.1.0 milestone Nov 7, 2016
@lunny lunny removed the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 7, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
* Panic if Git version is < GitVersionRequired

* Update GitVersionRequired comment

* Correct copyright
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
* Add an head ref for the sake of using self repo for testing

* Add test for CommitCount

* Add testing with git-1.7.2

* Add test for GetLatestCommitTime

The test checks that latest commit time is before now
and more recent than the commit this PR is based at
Test no error is raised by time parsing and GetLatestCommitTime
Print actual time when tests fail

* Accept git 1.7.2 as the minimum version

Debian old old (very old) distribution (6.0 aka Squeeze)
ships version 1.7.10.4.

The version requirement was raised in go-gitea#46 supposedly for the
need of "symbolic-ref" command, but that command is supported
by the 1.7.2 version too, and possibly even older versions.

* Reduce output from drone, add comments

Reduce steps, concatenating them in logical steps

* Interrupt step upon first failure

* Add Dockerfile for use with ci

* Use ad-hoc docker image for testing git-1.7.2

* Avoid running build/vet/clean twice

* Set HEAD ref also in testing-1-7 step
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Jun 23, 2022
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants