Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill testing processes if the test takes too long #5174

Merged
merged 6 commits into from
Oct 29, 2018
Merged

Kill testing processes if the test takes too long #5174

merged 6 commits into from
Oct 29, 2018

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Oct 25, 2018 •
edited
Loading

A temporary band-aid to avoid resource-wasting CI build.
It prints the backtrace in case of timeout.

For #5172

@codecov-io
Copy link

codecov-io commented Oct 25, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@abf6e0d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5174   +/-   ##
=========================================
  Coverage          ?   37.52%           
=========================================
  Files             ?      309           
  Lines             ?    45820           
  Branches          ?        0           
=========================================
  Hits              ?    17195           
  Misses            ?    26163           
  Partials          ?     2462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf6e0d...cf2dce0. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2018
@typeless typeless force-pushed the debug-5172 branch 13 times, most recently from aa86ddd to e36ab79 Compare October 25, 2018 07:23
@typeless typeless changed the title [WIP] Kill testing processes if the test takes too long Kill testing processes if the test takes too long Oct 25, 2018
@lunny
Copy link
Member

lunny commented Oct 25, 2018

@typeless please resolve the conflict

@typeless
Copy link
Contributor Author

@lunny Done.

@lunny
Copy link
Member

lunny commented Oct 25, 2018

Could you reenable test-sqlite3 on this PR?

@typeless
Copy link
Contributor Author

@lunny Sure.

@lunny
Copy link
Member

lunny commented Oct 25, 2018

I restarted the CI 3 times and everytime CI passed and there is no timeout.

@lunny
Copy link
Member

lunny commented Oct 25, 2018

And the killing maybe unnecessary.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 25, 2018
@typeless
Copy link
Contributor Author

@lunny If there are no concerns, I would like to keep it longer or even apply to all the database tests in the hope that some mysterious, sporadic hanging bug can be spotted (which could be very hard to reproduce).

@lunny
Copy link
Member

lunny commented Oct 26, 2018

Yes, ten minutes maybe too short.

@typeless
Kill testing processes if the test takes too long
079ab37 
When timeout, Send ABRT signal to print backtraces for diagnosis.
The timeout value is set to 1200s (20mins) for now.
@typeless typeless mentioned this pull request Oct 26, 2018
Merged
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 29, 2018
@techknowlogick techknowlogick merged commit 7694c99 into go-gitea:master Oct 29, 2018
@typeless typeless deleted the debug-5172 branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@typeless @codecov-io @lunny @techknowlogick @lafriks @bkcsoft