Fix bug when users have serval teams with different units on different repositories #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5307 +/- ##
==========================================
+ Coverage 37.36% 37.38% +0.02%
==========================================
Files 312 312
Lines 46322 46330 +8
==========================================
+ Hits 17309 17322 +13
+ Misses 26531 26527 -4
+ Partials 2482 2481 -1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
BetaCat0
approved these changes
Nov 9, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Nov 9, 2018
bkcsoft
added
lgtm/done
|
@lunny please send backport |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Nov 9, 2018
This was referenced Nov 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user are on two teams on the same organization and get units will get non-current repository teams and units. This pull request will add a filter so that a repository get units only the repository's teams, not all the teams of the user.