Refactor issue indexer #5363
Merged
Refactor issue indexer #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/refactoring
lunny
force-pushed
the
lunny/indexer_interface
branch
from
1155231
to
c17f19d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5363 +/- ##
==========================================
- Coverage 38.84% 38.79% -0.05%
==========================================
Files 349 353 +4
Lines 49801 50109 +308
==========================================
+ Hits 19346 19442 +96
- Misses 27655 27853 +198
- Partials 2800 2814 +14
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/indexer_interface
branch
from
d7e7473
to
238bec6
Compare
|
It's ready to review. |
lunny
removed
the
pr/breaking
lunny
force-pushed
the
lunny/indexer_interface
branch
2 times, most recently
from
5092ca5
to
5d965a5
Compare
lunny
force-pushed
the
lunny/indexer_interface
branch
2 times, most recently
from
2d527e9
to
45a6026
Compare
lafriks
approved these changes
Feb 17, 2019
GiteaBot
added
lgtm/need 1
zeripath
reviewed
Feb 17, 2019
modules/setting/setting.go
Outdated
| @@ -1215,6 +1232,22 @@ func NewContext() { | |||
| // Explicitly disable credential helper, otherwise Git credentials might leak | |||
| git.GlobalCommandArgs = append(git.GlobalCommandArgs, "-c", "credential.helper=") | |||
| } | |||
|
|
|||
| sec = Cfg.Section("indexer") | |||
There was a problem hiding this comment.
Can we split this out to modules/setting/indexer.go?
Gopkg.toml
Outdated
| @@ -119,4 +119,4 @@ ignored = ["google.golang.org/appengine*"] | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/prometheus/client_golang" | |||
| version = "0.9.0" | |||
| version = "0.9.0" | |||
There was a problem hiding this comment.
This probably should have a new line at the end of this file.
| @@ -7,25 +7,60 @@ package models | |||
| import ( | |||
There was a problem hiding this comment.
Probably out of scope for this PR, but I wonder if we really want this functionality in models/ rather than in modules/indexer/. (Obviously out of scope: I think we probably need to restructure models to make it less of a grab-bag of everything and try to move struct into perhaps a core-models and peripheral/plugin system. )
There was a problem hiding this comment.
I would like to do that, but it will change more files. I prefer to do that on another refactor PRs.
lunny
force-pushed
the
lunny/indexer_interface
branch
from
b4f8e17
to
2e89743
Compare
|
Moving back to 1.8.0 |
zeripath
approved these changes
Feb 19, 2019
GiteaBot
added
lgtm/done
This was referenced Feb 19, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor issue indexer implementation and create two interface, one is
Indexeranother isQueueand provideBleveIndexer,ChannelQueuueandLevelQueue. And you can add new implementation after this PR merged.This PR will keep the issue indexer compitable with lower Gitea version.
EDIT: This PR also fixed some bugs on indexing and added delete index when deleting a repository or future deleting a standalone issue or pull request.