Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add require attribute to target param on releases #5477

Closed
wants to merge 4 commits into from
Closed

add require attribute to target param on releases #5477

wants to merge 4 commits into from

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Dec 5, 2018

Fix #5471

commands I ran to get to this point:

cd go/src/code.gitea.io/gitea
git pull
git checkout -b issue-5471
dep ensure -update code.gitea.io/sdk
git add .
git commit -m "update sdk vendor"
git push origin issue-5471

@techknowlogick
Copy link
Member Author

blocked by #5419

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2018
@techknowlogick techknowlogick added this to the 1.7.0 milestone Dec 5, 2018
@techknowlogick techknowlogick added type/bug status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Dec 5, 2018
@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #5477 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5477   +/-   ##
=======================================
  Coverage   37.51%   37.51%           
=======================================
  Files         322      322           
  Lines       47458    47458           
=======================================
  Hits        17804    17804           
  Misses      27097    27097           
  Partials     2557     2557

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945804f...e648128. Read the comment docs.

@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Jan 5, 2019
@techknowlogick
Copy link
Member Author

Closing as it breaks drone gitea plugin.

@techknowlogick techknowlogick removed this from the 1.8.0 milestone Jan 27, 2019
@techknowlogick techknowlogick deleted the issue-5471 branch February 15, 2019 06:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /api/v1/releases should require target parameter
3 participants