Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix adding reaction fail for read permission user #5515

Merged
merged 2 commits into from
Dec 11, 2018
Merged

fix adding reaction fail for read permission user #5515

merged 2 commits into from
Dec 11, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

A read permission user to a repo should add reaction to an issue or comment.
caused by #5314

@lunny lunny added the type/bug label Dec 11, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018
@lunny lunny changed the title fix adding reaction fail for read permission fix adding reaction fail for read permission user Dec 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #5515 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5515      +/-   ##
==========================================
+ Coverage   37.61%   37.62%   +<.01%     
==========================================
  Files         317      317              
  Lines       46835    46835              
==========================================
+ Hits        17619    17621       +2     
+ Misses      26712    26710       -2     
  Partials     2504     2504
Impacted Files Coverage Δ
routers/repo/issue.go 37.55% <0%> (ø) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64680b7...b451bb7. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit ccea916 into go-gitea:master Dec 11, 2018
@lunny lunny deleted the lunny/fix_reaction branch December 12, 2018 00:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @lafriks @adelowo @techknowlogick @bkcsoft