Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix public will not be reused as public key after deleting as deploy key #5671

Merged
merged 3 commits into from
Jan 9, 2019
Merged

fix public will not be reused as public key after deleting as deploy key #5671

merged 3 commits into from
Jan 9, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 9, 2019

Will fix #1357

@lunny lunny added this to the 1.8.0 milestone Jan 9, 2019
@lunny lunny mentioned this pull request Jan 9, 2019
Closed
5 tasks
@codecov-io
Copy link

codecov-io commented Jan 9, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@530c2b8). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5671   +/-   ##
=========================================
  Coverage          ?   37.77%           
=========================================
  Files             ?      323           
  Lines             ?    47595           
  Branches          ?        0           
=========================================
  Hits              ?    17977           
  Misses            ?    27029           
  Partials          ?     2589
Impacted Files Coverage Δ
models/ssh_key.go 40.23% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530c2b8...8c770b9. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2019
zeripath
zeripath approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, I think I've looked at this code before and wondered why it didn't need to rewrite the public keys! Turns out it did!!

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2019
@lunny
Copy link
Member Author

lunny commented Jan 9, 2019

@zeripath I just take a look and found the problem. Sorry to post a PR before you! :)

@zeripath
Copy link
Contributor

zeripath commented Jan 9, 2019

No probs, as I said, I saw it and ignored it. That'll teach me! I think I may just need to be more suspicious.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2019
@techknowlogick techknowlogick merged commit 0b84b5e into go-gitea:master Jan 9, 2019
lunny added a commit to lunny/gitea that referenced this pull request Jan 10, 2019
@lunny
fix public will not be reused as public key after deleting as deploy …
0f05c2d 
…key (go-gitea#5671)
@lunny lunny mentioned this pull request Jan 10, 2019
Merged
lunny added a commit to lunny/gitea that referenced this pull request Jan 10, 2019
@lunny
fix public will not be reused as public key after deleting as deploy …
477c128 
…key (go-gitea#5671)
@lunny lunny mentioned this pull request Jan 10, 2019
Merged
@lunny lunny deleted the lunny/fix_del_deploy_key_not_reuse branch January 10, 2019 04:15
@lunny lunny added the backport/done All backports for this PR have been created label Jan 10, 2019
techknowlogick pushed a commit that referenced this pull request Jan 10, 2019
@lunny @techknowlogick
fix public will not be reused as public key after deleting as deploy …
1c4293b 
…key (#5671) (#5685)
techknowlogick pushed a commit that referenced this pull request Jan 10, 2019
@lunny @techknowlogick
fix public will not be reused as public key after deleting as deploy …
483aa06 
…key (#5671) (#5684)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Deploy Key can't be deleted then reused as Profile key
6 participants
@lunny @codecov-io @zeripath @adelowo @techknowlogick @bkcsoft