Moved defaults in defaults.go to setting.go

[jolheiser]

As titled, I moved the few defaults in defaults.go to setting.go and removed defaults.go since it was then unused.

[codecov-io]

Codecov Report

Merging #5764 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5764      +/-   ##
==========================================
+ Coverage   37.72%   37.73%   +0.01%     
==========================================
  Files         327      327              
  Lines       47818    47824       +6     
==========================================
+ Hits        18037    18047      +10     
+ Misses      27188    27184       -4     
  Partials     2593     2593

Impacted Files	Coverage Δ
modules/setting/setting.go	49.19% <100%> (+0.38%)	⬆️
routers/repo/view.go	47.3% <0%> (+1.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6822a89...5c25aa8. Read the comment docs.

[adelowo]

¯_(ツ)_/¯

[zeripath]

Hmm this looks like it's a nice simple fix but I don't know enough about our infrastructure - is it possible that our crowdin script or another script uses the defaults.go? @tboerger do you know if any of our infrastructure (ab)uses this file?

[tboerger]

They are anyway not exported, they are not used anywhere else than this package.

[zeripath]

I meant is there a dirty bash script out there that will "parse" the defaults file and update its values.

[tboerger]

I have not introduced something hacky like that.

[zeripath]

Cool. Wasn't accusing, just aware that sometimes the most expedient and easiest option is to write scripts that generate or read code in other languages.

Then we can probably just approve this PR.

[zeripath]

BTW Is the capitalisation is an indication that the language's translation is (in)complete?

[zeripath]

We should probably actually autogenerate the list of translations available by looking at the language translation configuration files available.

[adelowo]

defaultThemes isn't here anyways

[lunny]

Please take defaultThemes back.

[zeripath]

@lunny defaultThemes isn't mentioned anywhere else in the codebase and appears to be completely redundant

$ grep -r defaultThemes ~/go/src/code.gitea.io/gitea                [16:36:01]
~/go/src/code.gitea.io/gitea/modules/setting/defaults.go:	defaultThemes                            = strings.Split("gitea", "arc-green")

[lunny]

@zeripath you are right. See https://github.com/go-gitea/gitea/blob/master/modules/setting/setting.go#L335

[adelowo]

Haha... Sorry my bad 😂. I could have sworn I used it somewhere