Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated dependency manager #58

Merged
merged 5 commits into from
Nov 4, 2016
Merged

Integrated dependency manager #58

merged 5 commits into from
Nov 4, 2016

Conversation

tboerger
Copy link
Member

@tboerger tboerger commented Nov 3, 2016

I have integrated all dependencies with govendor and also updated the travis configuration since we don't need to download the dependencies anymore. This also fixes #29.

bkcsoft
bkcsoft reviewed Nov 3, 2016
View reviewed changes
.travis.yml
script:
- go build -v -tags 'cert sqlite pam miniwinsvc'
- |
for pkg in $(go list ./... | grep -v /vendor/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't this be written as instead?

go test -v race -cover -coverprofile coverage.out $(go list ./... | grep -v /vendor/)

Or do we need to split them up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, cannot use test profile flag with multiple packages

@andreynering
Copy link
Contributor

andreynering commented Nov 3, 2016 •
edited
Loading

You forgot to vendor test packages. See the Travis output:

models/models_test.go:10:2: cannot find package "github.com/smartystreets/goconvey/convey" in any of:
    /home/travis/gopath/src/github.com/go-gitea/gitea/vendor/github.com/smartystreets/goconvey/convey (vendor tree)
    /home/travis/.gimme/versions/go1.6.linux.amd64/src/github.com/smartystreets/goconvey/convey (from $GOROOT)
    /home/travis/gopath/src/github.com/smartystreets/goconvey/convey (from $GOPATH)

@tboerger
Copy link
Member Author

tboerger commented Nov 3, 2016

You forgot to vendor test packages. See the Trivis output

Working on it.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger
Copy link
Member Author

tboerger commented Nov 3, 2016

Ready for review/merge

@bkcsoft
Copy link
Member

bkcsoft commented Nov 4, 2016

LGTM

@tboerger
Copy link
Member Author

tboerger commented Nov 4, 2016

Rebased

@lunny
Copy link
Member

lunny commented Nov 4, 2016

LGTM

@lunny lunny merged commit 4a5faec into master Nov 4, 2016
@tboerger tboerger deleted the vendoring branch November 4, 2016 08:23
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@ethantkoenig @lunny
Fix parsing bug in GetTagInfos (go-gitea#58)
544c5b3 
* Fix parsing bug in GetTagInfos

* Comment
@fakuivan fakuivan mentioned this pull request Jul 17, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkcsoft bkcsoft bkcsoft left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Integrate dependency manager
4 participants
@tboerger @andreynering @bkcsoft @lunny