Revert #3711 overwrite on #2167 #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Merged
Codecov Report
@@ Coverage Diff @@
## master #5836 +/- ##
==========================================
- Coverage 37.85% 37.85% -0.01%
==========================================
Files 328 328
Lines 48326 48326
==========================================
- Hits 18294 18292 -2
- Misses 27399 27401 +2
Partials 2633 2633
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
Add a test with reference to #2167 in the comments so that this doesn't happen again |
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
|
Tests added. |
lafriks
reviewed
Jan 25, 2019
Change 0/1 to false/true and remove repetitive code Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
lafriks
approved these changes
Jan 27, 2019
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Jan 27, 2019
GiteaBot
added
lgtm/done
bmackinney
pushed a commit
to bmackinney/gitea
that referenced
this pull request
Jan 27, 2019
…admins go-gitea#2167 (go-gitea#5836) Revert go-gitea#3711 overwrite of only show "No Description" to repo admins go-gitea#2167 and add tests to prevent accidental overwrite again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Silva Simões simoes.sgabriel@gmail.com