Fix wording of #5858 issue.review.reject string #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per @lafriks comment this should be: requested changes Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5869 +/- ##
=========================================
Coverage ? 37.86%
=========================================
Files ? 328
Lines ? 48326
Branches ? 0
=========================================
Hits ? 18299
Misses ? 27398
Partials ? 2629Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
adelowo
approved these changes
Jan 27, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 27, 2019
GiteaBot
added
lgtm/done
bmackinney
pushed a commit
to bmackinney/gitea
that referenced
this pull request
Jan 27, 2019
As per @lafriks comment this should be: requested changes Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @lafriks comment this should be (in English): "requested changes %s"
Signed-off-by: Andrew Thornton art27@cantab.net