Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reviews on a deleted file path #5880

Merged
merged 4 commits into from
Feb 1, 2019
Merged

support reviews on a deleted file path #5880

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae248ac
support reviewing on a deleted file path
adelowo Jan 28, 2019
a73b4a5
Merge branch 'master' into fix_5418
techknowlogick Jan 28, 2019
60134bb
Merge branch 'master' into fix_5418
adelowo Jan 31, 2019
aa67f8e
Merge branch 'master' into fix_5418
lunny Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions models/issue_comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,10 +873,11 @@ func CreateCodeComment(doer *User, repo *Repository, issue *Issue, content, tree
// No need for get commit for base branch changes
if line > 0 {
commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line))
if err != nil {
if err == nil {
commitID = commit.ID.String()
} else if err != nil && !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") {
return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err)
}
commitID = commit.ID.String()
}

// Only fetch diff if comment is review comment
Expand Down