Ensure repo is loaded in mailer (Completely fix #5891) #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5895 +/- ##
========================================
Coverage ? 38%
========================================
Files ? 328
Lines ? 48331
Branches ? 0
========================================
Hits ? 18370
Misses ? 27322
Partials ? 2639
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 29, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Jan 29, 2019
GiteaBot
added
lgtm/done
zeripath
added a commit
that referenced
this pull request
Jan 29, 2019
…) (#5894) * Ensure issue.Poster is loaded in mailIssueCommentToParticipants (#5891) Previous code could potentially dereference nil - this PR ensures that the poster is loaded before dereferencing it. Signed-off-by: Andrew Thornton <art27@cantab.net> * Also ensure the repo is loaded Signed-off-by: Andrew Thornton <art27@cantab.net>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it appears that the master branch is currently protected against the nil dereference bug referred to in #5891 - looking closer at the functions this calls these expect that the repo is loaded in the issue, which may not be available.
This fix ensures that the repo is loaded before calling these methods meaning that any future changes will be protected against a nil dereference. (We should probably also "MustRepo" in those downstream functions - however, injudicious use could cause deadlocks.)
Signed-off-by: Andrew Thornton art27@cantab.net