-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Move migration git clone to its own goroutine #5949
WIP: Move migration git clone to its own goroutine #5949
Conversation
|
e20736d
to
e9dd53b
Compare
The current code places the git clone in the POST goroutine, blocking that goroutine until it is finished. This PR asynchronises this, placing the clone within its own goroutine. Fix go-gitea#3770
e9dd53b
to
938026f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5949 +/- ##
=========================================
+ Coverage 38.86% 38.9% +0.04%
=========================================
Files 345 346 +1
Lines 49510 49670 +160
=========================================
+ Hits 19241 19324 +83
- Misses 27486 27553 +67
- Partials 2783 2793 +10
Continue to review full report at Codecov.
|
Ok, this is now working. In terms of things that could be done:
|
Signed-off-by: Andrew Thornton <art27@cantab.net>
Closing this PR in preference to lunny's |
The current code places the git clone in the POST goroutine, blocking that goroutine until it is finished. This PR asynchronises this, placing the clone within its own goroutine. Fix #3770. Fix #1249.