Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look and feel improvements (black buttons/labels to blue buttons/labels) #5978

Closed
wants to merge 3 commits into from
Closed

Look and feel improvements (black buttons/labels to blue buttons/labels) #5978

wants to merge 3 commits into from

Conversation

metiftikci
Copy link
Contributor

I hate black buttons. Blue looks better for me. Is not it?
Black 1
Black 2
Blue 1
Blue 2

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 6, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 6, 2019
@codecov-io
Copy link

codecov-io commented Feb 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7a72aa6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5978   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      345           
  Lines             ?    49507           
  Branches          ?        0           
=========================================
  Hits              ?    19243           
  Misses            ?    27481           
  Partials          ?     2783

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a72aa6...23b28d1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2019
@metiftikci
Copy link
Contributor Author

Ooh god! Sorry im noob on contributing. But this is also kind of UI ^_^
Should i do something @techknowlogick ?

Old
old

New
new

@metiftikci metiftikci changed the title Look and feel improvements (black buttons to blue buttons). Look and feel improvements (black buttons/labels to blue buttons/labels) & Fix #5580 Feb 6, 2019
@lunny
Copy link
Member

lunny commented Feb 7, 2019

Please split this as two PRs.

@metiftikci metiftikci changed the title Look and feel improvements (black buttons/labels to blue buttons/labels) & Fix #5580 Look and feel improvements (black buttons/labels to blue buttons/labels) Feb 7, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2019
@adelowo
Copy link
Member

adelowo commented Feb 13, 2019

What does this look like on the dark theme?

hexfs
hexfs reviewed Feb 18, 2019
View reviewed changes
templates/repo/commits_table.tmpl
@@ -14,7 +14,7 @@
<input type="checkbox" name="all" id="all" value="true" {{.All}}>
<label for="all">{{.i18n.Tr "repo.commits.search_all"}} &nbsp;&nbsp;</label>
</div>
<button class="ui black tiny button" data-panel="#add-deploy-key-panel">{{.i18n.Tr "repo.commits.find"}}</button>
<button class="ui blue button" data-panel="#add-deploy-key-panel">{{.i18n.Tr "repo.commits.find"}}</button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button class="ui blue button" data-panel="#add-deploy-key-panel">{{.i18n.Tr "repo.commits.find"}}</button>
<button class="ui blue tiny button" data-panel="#add-deploy-key-panel">{{.i18n.Tr "repo.commits.find"}}</button>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like better without 'tiny' class i guess

hexfs
hexfs suggested changes Feb 18, 2019
View reviewed changes
Copy link

@hexfs hexfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @adelowo asked how does it look like on dark theme?

@ntimo
Copy link

ntimo commented Feb 22, 2019

To be honest, I think the black buttons look better. Why does this has to be changed?

@lafriks lafriks modified the milestones: 1.8.0, 1.9.0 Feb 23, 2019
@stale
Copy link

stale bot commented Apr 24, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 24, 2019
kolaente
kolaente reviewed May 13, 2019
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

@stale stale bot removed the issue/stale label May 13, 2019
@metiftikci
Copy link
Contributor Author

@silverwind can you make this change for me? It is hard to work on windows for me.
Im closing this PR, im sorry for that.

@metiftikci metiftikci closed this Jun 13, 2019
@silverwind
Copy link
Member

Maybe yes. I'd probably do something closer to GitHub thought, e.g. a colored icon, not a "button".

@jaqra jaqra mentioned this pull request Aug 27, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente left review comments

@hexfs hexfs hexfs requested changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.