-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoprefixer to css build #6029
Conversation
331af28
to
db8fc20
Compare
Codecov Report
@@ Coverage Diff @@
## master #6029 +/- ##
==========================================
+ Coverage 38.72% 38.72% +<.01%
==========================================
Files 339 339
Lines 49013 49013
==========================================
+ Hits 18980 18982 +2
+ Misses 27287 27284 -3
- Partials 2746 2747 +1
Continue to review full report at Codecov.
|
One rather important consideration when vendoring node_modules is that if a module or one if its dependencies includes a native compiled (and platform-specific) module (identified by a |
I honestly don't think it makes sense to vendor By the way, see go modules have a limit of 500MiB. I am not certain if 500MiB is for just Go source files or the entire repository size. This might be something to consider |
I would also prefer to not have node_modules in git |
I just thought it might be appreciated because the golang modules are vendored too, but I guess I'll undo it. Not a huge fan of it myself because of the mentioned native module issue. |
db8fc20
to
2f4e094
Compare
2f4e094
to
80040cc
Compare
80040cc
to
6c4cb75
Compare
Reworked PR, now only includes autoprefixer. The |
- node_modules is now vendored (second commit), making it easier for contributors to run the css build as well as ensuring everyone uses the same node dependency versions.- addedmake css
target. Less to type and the old target is still available and will print a deprecation warning.- addedmake update-node-modules
which will update all node dependencies and remove unnecessary files in node_modules.Edit: The PR previously contained some controversial changes, removed them.