Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make document body a flexbox #6139

Merged
merged 5 commits into from
Feb 24, 2019
Merged

UI: Make document body a flexbox #6139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c1f37a
UI: Make document body a flexbox
silverwind Feb 20, 2019
90a0b3a
ie11 fixes
silverwind Feb 24, 2019
e12b5ef
increase padding to 80px
silverwind Feb 24, 2019
29e1b94
add flex-grow
silverwind Feb 24, 2019
26260ef
Merge branch 'master' into body-flex
zeripath Feb 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ generate-stylesheets:
echo "Please install npm version 5.2+"; \
exit 1; \
fi;
$(eval BROWSERS := "> 2%, last 2 firefox versions, last 2 safari versions")
$(eval BROWSERS := "> 1%, last 2 firefox versions, last 2 safari versions, ie 11")
npx lessc --clean-css public/less/index.less public/css/index.css
$(foreach file, $(filter-out public/less/themes/_base.less, $(wildcard public/less/themes/*)),npx lessc --clean-css public/less/themes/$(notdir $(file)) > public/css/theme-$(notdir $(call strip-suffix,$(file))).css;)
$(foreach file, $(wildcard public/css/*),npx postcss --use autoprefixer --autoprefixer.browsers $(BROWSERS) -o $(file) $(file);)
Expand Down
2 changes: 1 addition & 1 deletion public/css/index.css
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion public/less/_admin.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.admin {
padding-top: 15px;
padding-bottom: @footer-margin * 2;

.table.segment {
padding: 0;
Expand Down
12 changes: 5 additions & 7 deletions public/less/_base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@footer-margin: 40px;

body {
font-family: "Lato", "Segoe UI", "Microsoft YaHei", Arial, Helvetica, sans-serif !important;
background-color: #fff;
overflow-y: scroll;
-webkit-font-smoothing: antialiased;
display: flex;
flex-direction: column;
}
img {
border-radius: 3px;
Expand Down Expand Up @@ -56,9 +56,8 @@ pre, code {
hyphens: auto;
}
.full.height {
padding: 0;
margin: 0 0 calc(-@footer-margin - 2px) 0;
min-height: 100%;
flex-grow: 1;
padding-bottom: 80px;
}
.following.bar {
z-index: 900;
Expand Down Expand Up @@ -440,11 +439,10 @@ pre, code {
}

footer {
position: absolute;
background-color: white;
border-top: 1px solid #d6d6d6;
clear: both;
width: 100%;
height: 40px;
color: #888888;
.container {
width: 100vw !important;
Expand Down
1 change: 0 additions & 1 deletion public/less/_dashboard.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.dashboard {
padding-top: 15px;
padding-bottom: @footer-margin * 2;

&.feeds,
&.issues {
Expand Down
1 change: 0 additions & 1 deletion public/less/_explore.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.explore {
padding-top: 15px;
padding-bottom: @footer-margin * 2;

.navbar {
justify-content: center;
Expand Down
2 changes: 0 additions & 2 deletions public/less/_home.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.home {
padding-bottom: @footer-margin * 2;
.logo {
max-width: 220px;
}
Expand Down Expand Up @@ -45,7 +44,6 @@

.signup {
padding-top: 15px;
padding-bottom: @footer-margin * 2;
}

footer {
Expand Down
1 change: 0 additions & 1 deletion public/less/_install.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.install {
padding-top: 45px;
padding-bottom: @footer-margin * 2;
form {
@input-padding: 320px !important;
label {
Expand Down
1 change: 0 additions & 1 deletion public/less/_organization.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.organization {
padding-top: 15px;
padding-bottom: @footer-margin * 2;

.head {
.ui.header {
Expand Down
1 change: 0 additions & 1 deletion public/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
@mega-octicon-width: 30px;

padding-top: 15px;
padding-bottom: @footer-margin * 2;

.repo-header {
.ui.compact.menu {
Expand Down
1 change: 0 additions & 1 deletion public/less/_user.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.user {
&:not(.icon) {
padding-top: 15px;
padding-bottom: @footer-margin * 2;
}

&.profile {
Expand Down