Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attributes to all items in the repo list viewer #6258

Merged
merged 7 commits into from
Mar 19, 2019
Merged

Add title attributes to all items in the repo list viewer #6258

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03c8bd5
Adds title attributes to all items in the repo list viewer
jolheiser Mar 6, 2019
fb204c2
Suggested change
jolheiser Mar 14, 2019
28dada7
Revert change
jolheiser Mar 14, 2019
e784a29
Merge branch 'master' into 6256_long_name_title
jolheiser Mar 14, 2019
b2887bd
Merge branch 'master' into 6256_long_name_title
lunny Mar 16, 2019
3921d2b
Merge branch 'master' into 6256_long_name_title
jolheiser Mar 18, 2019
a1fe457
Merge branch 'master' into 6256_long_name_title
techknowlogick Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/repo/view_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
{{$subJumpablePathName := $entry.GetSubJumpablePathName}}
{{$subJumpablePath := SubJumpablePath $subJumpablePathName}}
<span class="octicon octicon-file-directory"></span>
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $subJumpablePathName}}">
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $subJumpablePathName}}" title="{{$subJumpablePathName}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe still EscapePound ?

Copy link
Member Author

@jolheiser jolheiser Mar 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the title, I don't think it needs to be escaped since EscapePound is for URLs , right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template library should automatically ensure that the {{$subJumpablePathName}} is appropriately encoded for attributes.

{{if eq (len $subJumpablePath) 2}}
<span class="jumpable-path">{{index $subJumpablePath 0}}</span>{{index $subJumpablePath 1}}
{{else}}
Expand All @@ -74,7 +74,7 @@
</a>
{{else}}
<span class="octicon octicon-{{EntryIcon $entry}}"></span>
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $entry.Name}}">{{$entry.Name}}</a>
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $entry.Name}}" title="{{$entry.Name}}">{{$entry.Name}}</a>
{{end}}
</td>
{{end}}
Expand Down