Hacky fix for alignment of the create-organization dialog #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
reviewed
Mar 28, 2019
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #6455 +/- ##
==========================================
- Coverage 39.39% 39.39% -0.01%
==========================================
Files 393 393
Lines 53271 53271
==========================================
- Hits 20988 20986 -2
- Misses 29297 29299 +2
Partials 2986 2986
Continue to review full report at Codecov.
|
adelowo
approved these changes
Mar 28, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Mar 28, 2019
GiteaBot
added
lgtm/done
|
It truly is horrible and I'm both quite ashamed but also slightly proud of its hackery. Mostly it's just so we have something working for 1.8 so hopefully we'll get this properly fixed before too long. |
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests a somewhat hacky fix for the bug in #6376.
The issue is that semantic UI doesn't really provide an inline grouped radiobox format.
This PR hacks its way around this by creating empty labels to force semantic to display the radio boxes under each other.