Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI commands to manage LDAP authentication source #6681

Merged
merged 14 commits into from
Jun 17, 2019
Merged

Add CLI commands to manage LDAP authentication source #6681

merged 14 commits into from
Jun 17, 2019

Conversation

ngourdon
Copy link
Contributor

Add 4 CLI commands:

  • add-ldap: Add new LDAP (via Bind DN) authentication source
  • update-ldap: Update existing LDAP (via Bind DN) authentication source
  • add-ldap-simple: Add new LDAP (simple auth) authentication source
  • update-ldap-simple: Update existing LDAP (simple auth) authentication source

#5726

@codecov-io
Copy link

codecov-io commented Apr 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a200ca1). Click here to learn what that means.
The diff coverage is 80.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6681   +/-   ##
=========================================
  Coverage          ?   40.96%           
=========================================
  Files             ?      462           
  Lines             ?    62567           
  Branches          ?        0           
=========================================
  Hits              ?    25628           
  Misses            ?    33577           
  Partials          ?     3362
Impacted Files Coverage Δ
cmd/admin.go 0% <ø> (ø)
cmd/admin_auth_ldap.go 80.68% <80.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a200ca1...17afa58. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2019
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 19, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 19, 2019
@ngourdon
Copy link
Contributor Author

Gogs copyright is removed.
I also updated func parseLoginSource which wasn't right

adelowo
adelowo reviewed Apr 21, 2019
View reviewed changes
cmd/admin_auth_ldap.go Outdated Show resolved Hide resolved
@adelowo @ngourdon
fix comment
617caba 
Co-Authored-By: ngourdon <31291059+ngourdon@users.noreply.github.com>
@ngourdon
Copy link
Contributor Author

ngourdon commented May 1, 2019

Is there anything else needed for approval?

zeripath
zeripath reviewed May 1, 2019
View reviewed changes
cmd/admin_auth_ldap.go Outdated Show resolved Hide resolved
@ngourdon
Copy link
Contributor Author

ngourdon commented May 2, 2019

@zeripath config flag removed

@zeripath
Copy link
Contributor

zeripath commented May 2, 2019

@ngourdon sorry I didn't get a chance to properly look at this this evening. I'll try to review tomorrow evening UK time.

@zeripath zeripath mentioned this pull request May 28, 2019
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 5, 2019
@techknowlogick techknowlogick merged commit a618df8 into go-gitea:master Jun 17, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@ngourdon @jeffliu27
Add CLI commands to manage LDAP authentication source (go-gitea#6681)
e012b4e 
* add CLI commands to manage LDAP authentication source

* delete Gogs copyright

* remove unused return value of func parseLoginSource

* fix comment

Co-Authored-By: ngourdon <31291059+ngourdon@users.noreply.github.com>

* remove config flag already present in global flags

* remove config flag from ldap commands in docs

* remove config flag handling
@stertingen stertingen mentioned this pull request Jul 19, 2019
Closed
7 tasks
@stertingen stertingen mentioned this pull request Nov 3, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo left review comments

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ngourdon @codecov-io @zeripath @techknowlogick @adelowo @lafriks @GiteaBot @lunny