Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only return head: null if source branch was deleted (#6705) #7376

Merged
merged 1 commit into from
Jul 9, 2019
Merged

only return head: null if source branch was deleted (#6705) #7376

merged 1 commit into from
Jul 9, 2019

Conversation

quantonganh
Copy link
Contributor

  • only return head: null if source branch was deleted

  • add URL into GetPullRequest

  • TestPullRequest_APIFormat

  • log error if it is not Err(Branch)NotExist

(cherry picked from commit ff85a63)

Please check the following:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
  3. Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

@quantonganh quantonganh mentioned this pull request Jul 8, 2019
Merged
@lafriks lafriks added this to the 1.9.0 milestone Jul 8, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2019
@lafriks
Copy link
Member

lafriks commented Jul 8, 2019

@lunny you have pushed way too much commits imho

lafriks
lafriks requested changes Jul 8, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per comment above

@lunny
Copy link
Member

lunny commented Jul 8, 2019

@lunny you have pushed way too much commits imho

Maybe you mean @quantonganh ?

@lafriks
Copy link
Member

lafriks commented Jul 8, 2019

@lunny yes :) sorry

@quantonganh
only return head: null if source branch was deleted (go-gitea#6705)
b891427 
* only return head: null if source branch was deleted

* add URL into GetPullRequest

* TestPullRequest_APIFormat

* log error if it is not Err(Branch)NotExist

(cherry picked from commit ff85a63)
@quantonganh
Copy link
Contributor Author

@lafriks fixed.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2019
@lunny lunny merged commit 82d4d72 into go-gitea:release/v1.9 Jul 9, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@quantonganh @lafriks @lunny @zeripath @GiteaBot