Backport v1.9 - Fixes #7492 - Fixes for DeleteFilePost function to work properly #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmahn
changed the title
richmahn
changed the title
|
This could maybe be closed and a new PR with the updated/merged commit from master cherry picked to release/v1.9? |
GiteaBot
added
the
lgtm/need 2
|
@mrsdizzie That is possible. That PR has a few other fixes, not as urgent, but if ok with the admin, I think it would be good to get into v1.9 as it is weird how any file commit says when you make a new branch you will start a PR, but it doesn't do that. |
|
Ah OK sorry my mistake I read the description wrong -- I do think that change would be worth 1.9 as that is a bug otherwise, but that would be up to someone else |
|
@mrsdizzie Ok, here it is: #7507 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7492, backport for v1.9 from these fixes in PR #7478 for v1.10
Found that you could never get an error message when deleting a file as then it would try to use the edit file page template and that would throw errors. Also it had the wrong comparison sign for when looking to see if you can commit to the existing branch when you really want to make a new branch.F