-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drone/release-version: remove translations deps #7496
Merged
lunny
merged 1 commit into
go-gitea:master
from
sapk-fork:no-dep-translations-release-version
Jul 17, 2019
Merged
drone/release-version: remove translations deps #7496
lunny
merged 1 commit into
go-gitea:master
from
sapk-fork:no-dep-translations-release-version
Jul 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s only triggered by push on master
Codecov Report
@@ Coverage Diff @@
## master #7496 +/- ##
=========================================
- Coverage 41.22% 41.2% -0.02%
=========================================
Files 469 469
Lines 63533 63533
=========================================
- Hits 26191 26180 -11
- Misses 33924 33935 +11
Partials 3418 3418
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 17, 2019
lunny
approved these changes
Jul 17, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 17, 2019
mrsdizzie
approved these changes
Jul 17, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 17, 2019
sapk
added a commit
to sapk-fork/gitea
that referenced
this pull request
Jul 17, 2019
…s only triggered by push on master (go-gitea#7496)
techknowlogick
pushed a commit
that referenced
this pull request
Jul 18, 2019
* don't make release-version deps on transalations since translations is only triggered by push on master (#7496) * drone/docker: Use a more standard format (#7480) * drone/docker: Use a more standard format Based on the plugin drone structure itself : https://github.com/drone-plugins/drone-docker/blob/ebce953fc443371d79b5a019fcc9c1976f60a09a/.drone.yml#L9 Use autotag : http://plugins.drone.io/drone-plugins/drone-docker/#autotag * use latest plugins/docker:linux-amd64 * remove useless cache_from * Don't depends on translations step
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
…s only triggered by push on master (go-gitea#7496)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change drone to not make release-version depends on translations step since translations is only triggered by push on master and release-version on tag (that can occur on release branches)