Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 403 instead of 401 for ErrUserProhibitLogin #7591

Merged
merged 2 commits into from
Jul 23, 2019
Merged

use 403 instead of 401 for ErrUserProhibitLogin #7591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23d8574
use 403 instead of 401 for ErrUserProhibitLogin
zeripath Jul 23, 2019
85a4cf4
Merge branch 'master' into use-403-instead-of-401-in-ErrUserProhibitL…
zeripath Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func HTTP(ctx *context.Context) {
authUser, err = models.UserSignIn(authUsername, authPasswd)
if err != nil {
if models.IsErrUserProhibitLogin(err) {
ctx.HandleText(http.StatusUnauthorized, "User is not permitted to login")
ctx.HandleText(http.StatusForbidden, "User is not permitted to login")
return
} else if !models.IsErrUserNotExist(err) {
ctx.ServerError("UserSignIn error: %v", err)
Expand Down