Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve .well-known username #7639

Conversation

ashimokawa
Copy link
Contributor

backport of #7637

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2019
@zeripath
Copy link
Contributor

I don't understand why but it appears that make swagger-generate and then commit the changes needs to performed.

@techknowlogick
Copy link
Member

techknowlogick commented Jul 26, 2019

Upstream swagger has changed output which we resolved in 1.9 and master. As we are releasing 1.9 soon I’m not sure this needs a backport to 1.8

@sapk
Copy link
Member

sapk commented Jul 30, 2019

We will just need to indicate that we strongly suggest to update to 1.9 branch due to security bug that will not be fixed in 1.8.
Or we can disable the swagger-check for 1.8 branch (to pass this PR) since it will not have any update later.

@techknowlogick
Copy link
Member

@sapk I'm writing the changelog for 1.9.0 right now, so I'm going to close this PR.

@Codeberg-org Codeberg-org deleted the reserve-well-known-names-backport-1.8 branch June 26, 2020 22:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants