Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked macaron/session and macaron/cache libraries #7696

Closed
wants to merge 1 commit into from

Conversation

tamalsaha
Copy link
Contributor

Fix #7670

Signed-off-by: Tamal Saha tamal@appscode.com

Fix go-gitea#7670

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Contributor Author

If you would approve https://gitea.com/macaron/session/pulls/7 , I would like to vendor that in this pr also.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 1, 2019
@tamalsaha
Copy link
Contributor Author

There is still dependency on

Should csrf and captcha plugin repos be forked too?

@techknowlogick
Copy link
Member

yes, let me fork them now.

@techknowlogick
Copy link
Member

@tamalsaha
Copy link
Contributor Author

Thanks @techknowlogick . Can you please add drone ci for those repos? I can open a pr after that.

@tamalsaha tamalsaha closed this Aug 23, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go-macaron/cache and go-macaron/session
3 participants