-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check commit message hashes before making links #7713
Check commit message hashes before making links #7713
Commits on Aug 2, 2019
-
Check commit message hashes before making links
Previously, when formatting commit messages, anything that looked like SHA1 hashes was turned into a link using regex. This meant that certain phrases or numbers such as `777777` or `deadbeef` could be recognized as a commit even if the repository has no commit with those hashes. This change will make it so that anything that looks like a SHA1 hash using regex will then also be checked to ensure that there is a commit in the repository with that hash before making a link. Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for e887f92 - Browse repository at this point
Copy the full SHA e887f92View commit details -
Use gogit to check if commit exists
This commit modifies the commit hash check in the render for commit messages to use gogit for better performance. Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for d7788bf - Browse repository at this point
Copy the full SHA d7788bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 582a180 - Browse repository at this point
Copy the full SHA 582a180View commit details
Commits on Aug 5, 2019
-
Use rev-parse to check if commit exists
Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for 5852974 - Browse repository at this point
Copy the full SHA 5852974View commit details -
Add and modify tests for checking hashes in html link rendering
Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for 026c84a - Browse repository at this point
Copy the full SHA 026c84aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 663bc8e - Browse repository at this point
Copy the full SHA 663bc8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ed0fe - Browse repository at this point
Copy the full SHA 74ed0feView commit details
Commits on Aug 6, 2019
-
Return error in sha1CurrentPatternProcessor
Co-Authored-By: mrsdizzie <info@mrsdizzie.com>
Configuration menu - View commit details
-
Copy full SHA for 28f561c - Browse repository at this point
Copy the full SHA 28f561cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0240571 - Browse repository at this point
Copy the full SHA 0240571View commit details -
Revert "Return error in sha1CurrentPatternProcessor"
This reverts commit 28f561c. Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for d6b0392 - Browse repository at this point
Copy the full SHA d6b0392View commit details
Commits on Aug 7, 2019
-
Add debug logging to sha1CurrentPatternProcessor
This will log errors by the git command run in sha1CurrentPatternProcessor if the error is one that was unexpected. Signed-off-by: Gary Kim <gary@garykim.dev>
Configuration menu - View commit details
-
Copy full SHA for 950152e - Browse repository at this point
Copy the full SHA 950152eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 953829d - Browse repository at this point
Copy the full SHA 953829dView commit details
Commits on Aug 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ca446de - Browse repository at this point
Copy the full SHA ca446deView commit details
Commits on Aug 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4e1795f - Browse repository at this point
Copy the full SHA 4e1795fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74b25b4 - Browse repository at this point
Copy the full SHA 74b25b4View commit details
Commits on Aug 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a137af0 - Browse repository at this point
Copy the full SHA a137af0View commit details
Commits on Aug 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dccd86d - Browse repository at this point
Copy the full SHA dccd86dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65e9ee0 - Browse repository at this point
Copy the full SHA 65e9ee0View commit details