Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit message hashes before making links #7713

Merged

Commits on Aug 2, 2019

  1. Check commit message hashes before making links

    Previously, when formatting commit messages, anything
    that looked like SHA1 hashes was turned into a link
    using regex. This meant that certain phrases or numbers
    such as `777777` or `deadbeef` could be recognized as a commit
    even if the repository has no commit with those hashes.
    
    This change will make it so that anything that looks
    like a SHA1 hash using regex will then also be checked
    to ensure that there is a commit in the repository
    with that hash before making a link.
    
    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e887f92 View commit details
    Browse the repository at this point in the history
  2. Use gogit to check if commit exists

    This commit modifies the commit hash check
    in the render for commit messages to use
    gogit for better performance.
    
    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d7788bf View commit details
    Browse the repository at this point in the history
  3. Make code cleaner

    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    582a180 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Use rev-parse to check if commit exists

    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    5852974 View commit details
    Browse the repository at this point in the history
  2. Add and modify tests for checking hashes in html link rendering

    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    026c84a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    663bc8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    74ed0fe View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Return error in sha1CurrentPatternProcessor

    Co-Authored-By: mrsdizzie <info@mrsdizzie.com>
    gary-kim and mrsdizzie authored Aug 6, 2019
    Configuration menu
    Copy the full SHA
    28f561c View commit details
    Browse the repository at this point in the history
  2. Import Gitea log module

    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    0240571 View commit details
    Browse the repository at this point in the history
  3. Revert "Return error in sha1CurrentPatternProcessor"

    This reverts commit 28f561c.
    
    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    d6b0392 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Add debug logging to sha1CurrentPatternProcessor

    This will log errors by the git command run in
    sha1CurrentPatternProcessor if the error is one
    that was unexpected.
    
    Signed-off-by: Gary Kim <gary@garykim.dev>
    gary-kim committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    950152e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    953829d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Configuration menu
    Copy the full SHA
    ca446de View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2019

  1. Configuration menu
    Copy the full SHA
    4e1795f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74b25b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Configuration menu
    Copy the full SHA
    a137af0 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Configuration menu
    Copy the full SHA
    dccd86d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65e9ee0 View commit details
    Browse the repository at this point in the history