Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment (NOT FOR MERGING): Add test to stress insert ... select for Issue #7959

Closed

Conversation

guillep2k
Copy link
Member

@guillep2k guillep2k commented Aug 24, 2019

This is a follow-up of #7950; i.e. an attempt to add tests for #7944. Se my comment at #7950 (comment)

I'm not sure whether this should be included in the master branch, but the tests are worth sharing IMO.

@guillep2k
Copy link
Member Author

Something wrong with the issue/comment template? Mmm....

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #7959 into master will increase coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7959      +/-   ##
==========================================
+ Coverage   41.48%   41.49%   +<.01%     
==========================================
  Files         479      479              
  Lines       63964    63966       +2     
==========================================
+ Hits        26534    26540       +6     
+ Misses      33975    33970       -5     
- Partials     3455     3456       +1
Impacted Files Coverage Δ
models/issue.go 50.03% <55.55%> (+0.07%) ⬆️
modules/log/log.go 69.36% <0%> (-2.71%) ⬇️
models/repo_list.go 72.5% <0%> (-1%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
routers/repo/view.go 43.54% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83db07...87b38a3. Read the comment docs.

@guillep2k
Copy link
Member Author

This is not working as intended... yet.

@guillep2k
Copy link
Member Author

The good news is that I've managed to create a test that can make this fail.
The bad news is that I've managed to create a test that can make this fail.

@guillep2k guillep2k closed this Aug 24, 2019
models/issue_stress.go Outdated Show resolved Hide resolved
integrations/issue_stress_test.go Show resolved Hide resolved
@guillep2k
Copy link
Member Author

Added transaction support

@guillep2k guillep2k reopened this Aug 25, 2019
@guillep2k
Copy link
Member Author

guillep2k commented Aug 25, 2019

@lunny Unfortunately, adding transactions did not make any difference.

@guillep2k guillep2k changed the title WIP: Add test to stress insert ... select for Issue : Add test to stress insert ... select for Issue Aug 26, 2019
@guillep2k guillep2k changed the title : Add test to stress insert ... select for Issue Experiment (NOT FOR MERGING): Add test to stress insert ... select for Issue Aug 26, 2019
@guillep2k
Copy link
Member Author

Closing this in favor of #8005, which is independent of the method implemented in models.newIssue().

@guillep2k guillep2k closed this Aug 27, 2019
@guillep2k guillep2k deleted the issue-idx-insert-select-stress branch October 3, 2019 23:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants