-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to mod enabled version goquery #8021
Conversation
Build fails |
@lafriks @sapk I'm having the same problem in #7767 ;
|
I had too much confidence on a simple git rebase over master 😄. I will redo the step in #8019 (comment) and should be good. |
Or not |
@sapk I was about to tell you. That change is already merged and in my case, merging from it didn't help. |
What is strange is that google.golang.org/appengine v1.6.2 is not referenced in any go.mod |
Perhaps this has something to do with it? |
Yes but I cann't find a way to force the update on my machine... |
It could be a replication delay problem. The drone must be seeing the latest version, while our development servers have outdated cached information. |
You know Google... they must have hundreds of copies of this server around the world. It's probably a matter of waiting a couple of hours. |
Yes I try to set GOPROXY to the one from CI but with no luck. I updated manually the module.txt |
I'll try that myself. |
Codecov Report
@@ Coverage Diff @@
## master #8021 +/- ##
==========================================
- Coverage 41.6% 41.58% -0.02%
==========================================
Files 479 479
Lines 64106 64106
==========================================
- Hits 26669 26661 -8
- Misses 33979 33988 +9
+ Partials 3458 3457 -1
Continue to review full report at Codecov.
|
Changelog: PuerkitoBio/goquery@ed7d758...v1.5.0