Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vendor modules.txt #8032

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Aug 29, 2019

Otherwise build fails in all PRs

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 29, 2019
@lafriks lafriks added this to the 1.10.0 milestone Aug 29, 2019
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A make vendor will overwrite this, but until everybody is getting the new version, there's not much else we can do, I think.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #8032 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8032      +/-   ##
==========================================
- Coverage    41.6%   41.59%   -0.01%     
==========================================
  Files         479      479              
  Lines       64106    64106              
==========================================
- Hits        26669    26667       -2     
- Misses      33979    33981       +2     
  Partials     3458     3458
Impacted Files Coverage Δ
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187ae10...e23de77. Read the comment docs.

@lafriks lafriks merged commit 9ef1e5d into go-gitea:master Aug 29, 2019
@lafriks lafriks deleted the fix/vendor_modules branch August 29, 2019 13:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants