updated linux systemd service example and documentation #8109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
requested changes
Sep 5, 2019
| Group=git | ||
| WorkingDirectory=/var/lib/gitea/ | ||
| ExecStart=/usr/local/bin/gitea web -c /etc/gitea/app.ini | ||
| User=root |
There was a problem hiding this comment.
Gitea should not be run as root.
There was a problem hiding this comment.
Risk averse party poopers...
There was a problem hiding this comment.
Fine. I'll follow the binary install instructions on the actual Gitea site and see if the service works with the gitea.service file.
GiteaBot
added
the
lgtm/need 2
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
replaced by #8804 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the service.gitea file is not drop-in compatible with a bog standard install that runs Gitea as root with all the bits in the default places. The updated service file will work with no interesting changes.
One caveat is that the user still should uncomment whatever DB service that gitea should come online after... But, that isn't any different than it was.
The current example service file was good for showing how to customize starting Gitea, that inherent documentation was moved to the actual documentation.