Avoid including "num_issues" and "num_closed_issues" multiple times

[yzzyx]

Only update columns that have not been specified already in the query.

Fixes issue #8336.

[codecov-io]

Codecov Report

Merging #8337 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8337      +/-   ##
==========================================
+ Coverage   41.62%   41.63%   +<.01%     
==========================================
  Files         495      495              
  Lines       65523    65524       +1     
==========================================
+ Hits        27274    27280       +6     
+ Misses      34730    34725       -5     
  Partials     3519     3519

Impacted Files	Coverage Δ
models/issue_label.go	58.56% <100%> (+0.14%)	⬆️
models/repo_indexer.go	68.21% <0%> (+1.93%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177aedf...1d33dd2. Read the comment docs.

[guillep2k]

It looks like this should be taken into account by xorm, but it doesn't hurt handling it here as well.

[lafriks]

This should be fixed upstream in xorm (cc: @lunny ) as with this it will be harder to keep list updated if new columns are added to that table etc

[lunny]

I have sent go-xorm/xorm#1446, please wait for that merged. It's merged and we need a new PR on gitea to update xorm.

[guillep2k]

I have sent go-xorm/xorm#1446, please wait for that merged. It's merged and we need a new PR on gitea to update xorm.

@lunny we've recently adopted the tagged xorm 0.7.8. Should we reference master again?
Also, #8317 is already obsolete.

[sapk]

@guillep2k I merged #8317 as it still clean the double dependency and I think it is better to do it step by step. Just need to re-do the same steps like any update deps 😄

• tag xorm
• update xormstore
• update gitea xorm and xormstore deps (if possible in one PR)

[guillep2k]

@guillep2k I merged #8317 as it still clean the double dependency and I think it is better to do it step by step. Just need to re-do the same steps like any update deps 😄

* tag xorm

* update xormstore

* update gitea xorm and xormstore deps (if possible in one PR)

@sapk It makes sense. Let's wait for xorm to be tagged, then. Please you make the PR when that's ready.

[lunny]

I have tag xorm v0.7.9

[guillep2k]

I have tag xorm v0.7.9

@sapk Do you want to take care of the PR?

[sapk]

@guillep2k please go if you have time. I will maybe have time tonight but don't wait on me if you can do it.

[guillep2k]

@guillep2k please go if you have time. I will maybe have time tonight but don't wait on me if you can do it.

@sapk Oh, I thought you wanted to make a single PR containing both changes. I can do the Gitea part of course.

[yzzyx]

Fixed upstream in xorm, and with PR #8355, closing this pr.