Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for 1.10.0-RC1 #8510

Merged
merged 16 commits into from
Oct 14, 2019
Merged

Changelog for 1.10.0-RC1 #8510

merged 16 commits into from
Oct 14, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 14, 2019

finaly ;)

@6543 6543 force-pushed the changelog-1.10.0 branch from aff6bca to df42d3b Compare October 14, 2019 15:44
6543
6543 commented Oct 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2019
guillep2k
guillep2k reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543 and others added 2 commits October 14, 2019 17:52
@6543 @guillep2k
Update CHANGELOG.md
9f58854 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@6543
Merge branch 'master' into changelog-1.10.0
611a395
guillep2k
guillep2k reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543 and others added 2 commits October 14, 2019 17:56
@6543 @guillep2k
Update CHANGELOG.md
9141025 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@6543
Update CHANGELOG.md
267ad2b
jolheiser
jolheiser requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an RC first?

CHANGELOG.md Outdated Show resolved Hide resolved
@6543 @jolheiser
Update CHANGELOG.md
7eb152f 
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
lunny
lunny reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@8c8a93c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8510   +/-   ##
=========================================
  Coverage          ?   41.71%           
=========================================
  Files             ?      512           
  Lines             ?    66941           
  Branches          ?        0           
=========================================
  Hits              ?    27922           
  Misses            ?    35432           
  Partials          ?     3587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8a93c...5784087. Read the comment docs.

lafriks
lafriks reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Oct 14, 2019
@lafriks lafriks added this to the 1.10.0 milestone Oct 14, 2019
guillep2k
guillep2k reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
guillep2k
guillep2k reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Oct 14, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543 and others added 5 commits October 14, 2019 20:18
@6543
reslofe Fix XY statements
0010699
@6543
Update CHANGELOG.md
4e6041a
@6543 @guillep2k
Update CHANGELOG.md
cc38e6a 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@6543 @zeripath
Update CHANGELOG.md
00d1090 
Co-Authored-By: zeripath <art27@cantab.net>
@6543
Merge branch 'master' into changelog-1.10.0
94a07ef
zeripath
zeripath approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the Testing, Build and Docs sections remaining - but equally they could be removed.

@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 14, 2019
@6543 6543 changed the title Changelog for 1.10.0 Changelog for 1.10.0-RC1 Oct 14, 2019
6543
6543 commented Oct 14, 2019
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ready if you are?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2019
@6543
Copy link
Member Author

6543 commented Oct 14, 2019

ready 🚀

@zeripath zeripath merged commit db0d4ff into go-gitea:master Oct 14, 2019
@6543 6543 deleted the changelog-1.10.0 branch October 14, 2019 19:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k left review comments

@lunny lunny lunny left review comments

@jolheiser jolheiser jolheiser approved these changes

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
8 participants
@6543 @codecov-io @lunny @lafriks @zeripath @guillep2k @jolheiser @GiteaBot