-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add API for comment reactions #8823
Conversation
8881ade
to
83343fa
Compare
9606c96
to
ffb31cd
Compare
sometimes the CI doesnt now what to do ... so lest just restart it I'll write this long message of an empty commit just for funn > commit -m 'some message' --allow-empty and '-S' if you like to add Signature why this long text: just for funn
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #8823 +/- ##
==========================================
- Coverage 41.21% 41.13% -0.09%
==========================================
Files 543 543
Lines 69768 69950 +182
==========================================
+ Hits 28756 28773 +17
- Misses 37319 37486 +167
+ Partials 3693 3691 -2
Continue to review full report at Codecov.
|
@6543 type CommentReactionList []*CommentReaction I think what you want is type CommentReacionList struct {
CommentReactions []*CommentReaction `json:"comment_reactions"`
} or something similar Reflect is mad because a type definition reflection doesn't have a |
d7f50e7
to
d561946
Compare
@jolheiser thanks this fixes the reflection ... |
aa024e8
to
cf0332a
Compare
because there were no "reactions" anymore ... I'll implement the API like described in #8313 (comment) ... hopefully this is good enouth |
#9220 replace this PR |
close #8313