Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable lazy-loading of gitgraph.js #9036

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Commits on Nov 17, 2019

  1. enable lazy-loading of gitgraph.js

    - moved gitgraph.js to web_src and made it importable and es6-compatible
    - created new webpack chunk for gitgraph
    - enabled CSS loader in webpack
    - enabled async/await syntax via regenerator-runtime
    - added script to ensure webpack chunks are loaded correctly
    - disable terser's comment extraction to prevent .LICENCE files
    
    gitgraph.js has many issues:
    
    1. it is incompatible with ES6 because of strict-mode violations
    1. it does not export anything
    1. it's css has weird styles like for `body`
    1. it is not available on npm
    
    I fixed points 1-3 in our version so it's now loadable in webpack. We should eventually consider alternatives.
    silverwind committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    1936cac View commit details
    Browse the repository at this point in the history