Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of non-markdown readme files #95

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Fix rendering of non-markdown readme files #95

merged 1 commit into from
Nov 6, 2016

Conversation

odinuge
Copy link
Contributor

@odinuge odinuge commented Nov 6, 2016

Fix rendering of non-markdown readme files.

Issue: gogs/gogs/issues/3749

@odinuge
Copy link
Contributor Author

odinuge commented Nov 6, 2016

Isn't readmeExist more or less the same as isMarkdown in the fileRender function?

readmeExist := isMarkdown || markdown.IsReadmeFile(blob.Name())
That means "readmeExist" is true when you are rendering a normal non-readme markdown file.

Or what do you think?

@codecov-io
Copy link

codecov-io commented Nov 6, 2016 •
edited
Loading

Current coverage is 2.24% (diff: 100%)

No coverage report found for master at 6e4252d.

Powered by Codecov. Last update 6e4252d...530f6c1

@strk strk added this to the 1.0.0 milestone Nov 6, 2016
@strk strk added the type/bug label Nov 6, 2016
@strk
Copy link
Member

strk commented Nov 6, 2016

Inded those variable names are confusing.
readmeExist should be true even if the README is not in markdown format.

I've tested the fix and confirm it works. LGTM.

@metalmatze
Copy link
Contributor

LGTM

@metalmatze metalmatze merged commit 92c48da into go-gitea:master Nov 6, 2016
@odinuge odinuge deleted the readmeTxt branch November 6, 2016 19:19
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@jorgesumle jorgesumle mentioned this pull request Jan 23, 2017
Closed
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@mrexodia @lafriks
Improve memory usage in Commit.IsImageFile (go-gitea#95)
6196634 
Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@odinuge @codecov-io @strk @metalmatze @tboerger