Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a first draft for .drone.yml #96

Merged
merged 5 commits into from
Nov 24, 2016
Merged

Create a first draft for .drone.yml #96

merged 5 commits into from
Nov 24, 2016

Conversation

metalmatze
Copy link
Contributor

About a few things I'm not sure.

  1. I think we can stick with webhippie/golang:edge as build image
  2. Do we need CGO_ENABLED: 1?
  3. I disabled make lint because it throws > 500 errors.
  4. I'm not sure what's the correct way to call codecov right now.

@metalmatze metalmatze added type/enhancement An improvement of existing functionality type/question Issue needs no code to be fixed, only a description on how to fix it yourself. pr/wip This PR is not ready for review labels Nov 6, 2016
@tboerger
Copy link
Member

tboerger commented Nov 6, 2016

The image is my image and it's based on go shipped with alpine edge, should be fine for now.

Cgo should be disabled for now.

For the lint we got an open issue :)

tboerger
tboerger suggested changes Nov 6, 2016
View reviewed changes
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the required secrets later on.

.drone.yml

docker1:
image: plugins/docker
repo: go-gitea/gitea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitea/gitea

.drone.yml

docker2:
image: plugins/docker
repo: go-gitea/gitea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitea/gitea

.drone.yml

coverage:
image: plugins/coverage
server: http://coverage.dronehippie.de
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage.gitea.io

.drone.yml
image: webhippie/golang:edge
pull: true
environment:
CGO_ENABLED: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

.drone.yml

pipeline:
testing:
image: webhippie/golang:edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, we will add a matrix for that later

@metalmatze
Copy link
Contributor Author

drone currently blocks because:

'fail to parse public key: exec: "ssh-keygen": executable file not found in $PATH - exec: "ssh-keygen": executable file not found in $PATH'

@tboerger tboerger added this to the 1.0.0 milestone Nov 7, 2016
tboerger
tboerger reviewed Nov 7, 2016
View reviewed changes
.drone.yml
environment:
CGO_ENABLED: 0
commands:
- make clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a line like apk -U add openssh-client to fix the blocking about missing ssh-keygen.

.drone.yml

coverage:
image: plugins/coverage
server: http://coverage.gitea.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny should we setup a simple instance of Aircover for coverage reports? It's from the same author as LGTM and a simple docker container.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use Aircover not codecov-io?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because aircover is another nearly oss coverage tool we can also provide.

Just saying that because there is already a native plugin for that available.

We can also add gitea integration to that as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's not adding these annoying comments :P

@codecov-io
Copy link

codecov-io commented Nov 7, 2016 •
edited
Loading

Current coverage is 2.24% (diff: 100%)

No coverage report found for master at 6e4252d.

Powered by Codecov. Last update 6e4252d...e7b067f

@metalmatze
Copy link
Contributor Author

Drone passes now and is freakin' fast compared to travis 🎉

@strk
Copy link
Member

strk commented Nov 7, 2016

LGTM, so you don't miss one when needed :)

@tboerger
Copy link
Member

tboerger commented Nov 7, 2016

You should also install linux-pam-dev and set the same TAGS as the travis config via environment variable, e.g.

pipeline:
  testing:
    environment:
      CGO_ENABLED: 0
      TAGS: cert sqlite pam miniwinsvc

Beside that you can also integrate a matrix build for GO_VERSION 1.6 and 1.7, these tags also exist for webhippie/golang docker image. but make sure that many plugins should only execute on go 1.7.

This was referenced Nov 15, 2016
Merged
Closed
@strk
Copy link
Member

strk commented Nov 17, 2016

@tboerger your review was acted upon, could you give your approval so this can move further ? It is blocking #75

@strk strk mentioned this pull request Nov 19, 2016
Merged
@tboerger tboerger removed type/question Issue needs no code to be fixed, only a description on how to fix it yourself. pr/wip This PR is not ready for review labels Nov 24, 2016
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 24, 2016
@tboerger tboerger merged commit 21e8dee into go-gitea:master Nov 24, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 24, 2016

@metalmatze any reason for not using the official golang-image?

@tboerger
Copy link
Member

The official image doesn't have make on board, webhippie is my org, so we are really in control of the images :)

@metalmatze metalmatze deleted the feature/drone-config branch November 25, 2016 22:51
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
@richmahn
Fixes go-gitea#87 - Make hashtags hyperlinks in HTML view (go-gitea#96)
1fa996b 
* Fixes go-gitea#87 - Make Hashtags Hyperlinks in HTML view

* Added hashtag_test.go for testing
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@mrexodia @lafriks
Improve memory usage for Blob.Data() by ~50% (go-gitea#96)
f9dd682 
Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@tboerger tboerger tboerger approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@metalmatze @tboerger @codecov-io @strk @bkcsoft @lunny