Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement semantic label images #9607

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

jolheiser
Copy link
Member

Fix #9602

Using !important is not ideal, but this style is a copy from my instance which is before fomantic.
Please let me know if there is a better fix, I'd be happy to make further changes. 😃

Screenshot from 2020-01-04 20-38-46

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@techknowlogick techknowlogick added this to the 1.11.0 milestone Jan 5, 2020
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 5, 2020
@techknowlogick
Copy link
Member

Sadly fomantic, and semantic both require us to use a large amount for !important overrides, so I'm not too concerned with one more, as such this LGTM. Something we should look into improving, but not for 1.11 I think.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2020
@lafriks lafriks merged commit 4f54a46 into go-gitea:master Jan 5, 2020
@jolheiser jolheiser deleted the ui-label-img branch January 5, 2020 05:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [UI] avatar dimentions got lost after fomantic switch
4 participants