Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top author stats to activity page #9615

Merged
merged 12 commits into from
Jan 20, 2020
Merged

Add top author stats to activity page #9615

merged 12 commits into from
Jan 20, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 5, 2020 •
edited
Loading

Displays top ten authors from git history in specified period of time ordered in from most commits to least

image

image

@lafriks lafriks added type/enhancement An improvement of existing functionality type/changelog Adds the changelog for a new Gitea version labels Jan 5, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 6, 2020
guillep2k
guillep2k reviewed Jan 6, 2020
View reviewed changes
models/repo_activity.go Outdated Show resolved Hide resolved
templates/repo/activity.tmpl Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2020
@6543
Copy link
Member

6543 commented Jan 6, 2020 •
edited
Loading

I have no Idear why but the time-periode-drop-down-menue dont work on chrome anymore with this PR :(

EDIT: Firefox also affected

guillep2k
guillep2k approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The time-period-drop-down-menu mentioned by @6543 is worth a look; perhaps one of the updated libraries affected that, or the problem is in master already and not related to this PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2020
lunny
lunny reviewed Jan 8, 2020
View reviewed changes
package.json Show resolved Hide resolved
6543
6543 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm beside time-period-drop-down-menu

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
@lunny
Copy link
Member

lunny commented Jan 9, 2020

As what @6543 said, time-period-drop-down-menu is broken.

techknowlogick
techknowlogick previously requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking per @lunny comment

@6543
Copy link
Member

6543 commented Jan 14, 2020

any progress why this time-period-drop-down-menu thinkg is broken?

@lafriks
Copy link
Member Author

lafriks commented Jan 15, 2020

@techknowlogick @6543 somehow dropdown stops to work if placed inside Vue app, so I moved move app to smaller scope, works now

@zeripath zeripath changed the title Add top author stats to acitivity page Add top author stats to activity page Jan 15, 2020
sapk
sapk approved these changes Jan 16, 2020
View reviewed changes
web_src/js/index.js
@@ -6,6 +6,8 @@ import './publicPath.js';
import './gitGraphLoader.js';
import './semanticDropdown.js';

import ActivityTopAuthors from './components/ActivityTopAuthors.vue';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside this PR, we should maybe start doing code-splitting and lazy load components that are not always displayed/used now that we "build" all the frontend.

@sapk
Copy link
Member

sapk commented Jan 16, 2020 •
edited
Loading

Does @lunny and @techknowlogick concerns are solved ?

@codecov-io
Copy link

codecov-io commented Jan 16, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@def28ca). Click here to learn what that means.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9615   +/-   ##
=========================================
  Coverage          ?   42.31%           
=========================================
  Files             ?      605           
  Lines             ?    79296           
  Branches          ?        0           
=========================================
  Hits              ?    33552           
  Misses            ?    41605           
  Partials          ?     4139
Impacted Files Coverage Δ
modules/auth/auth_form.go 100% <ø> (ø)
modules/auth/ldap/ldap.go 54.4% <ø> (ø)
models/user.go 50.16% <0%> (ø)
cmd/admin_auth_ldap.go 79.32% <0%> (ø)
modules/markup/html.go 79.89% <100%> (ø)
routers/admin/auths.go 30.95% <100%> (ø)
modules/markup/sanitizer.go 86.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def28ca...6b7df1b. Read the comment docs.

@lafriks
Copy link
Member Author

lafriks commented Jan 16, 2020

@techknowlogick need your review

@sapk
Copy link
Member

sapk commented Jan 16, 2020

@lafriks some stats seems to have changed.

@techknowlogick techknowlogick dismissed their stale review January 19, 2020 18:00

dismiss my review

@lafriks lafriks merged commit 81cfe24 into go-gitea:master Jan 20, 2020
@lafriks lafriks deleted the feat/author_top branch January 20, 2020 10:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@6543 6543 6543 approved these changes

@guillep2k guillep2k guillep2k approved these changes

@sapk sapk sapk approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@lafriks @6543 @lunny @sapk @codecov-io @techknowlogick @guillep2k @GiteaBot @delvh @zeripath