Issue/PR Context Popups

[jolheiser]

Context popup when hovering over linked issue/PRs.

There are a few things missing because they weren't easily available, but overall I think this is enough to warrant a PR.

Action	Light	Dark
Open Issue
Closed Issue
Open PR
Closed PR
Merged PR
Bonus! Cross-Reference

[guillep2k]

This looks great. If this could be used for the PR list and show information like number of approvals, blocking issues or mergeability, we could tick a couple of boxes in #8659.

I'm approving nonetheless because that can be done in a 2nd PR.

[bagasme]

I think text inside the popup is almost unreadable on dark mode.

[silverwind]

Dark style needs some fixes. A less intense border and the triangle pointer. I'd suggest not styling this particular popup, but .ui.popup in dark style so it applies to all of them.

[jolheiser]

@silverwind I updated the OP screenshots, do they look better now?

@bagasme I tried to make the color lighter, but imho it looks better as-is. This is a little too bright.

For reference, the original color is the same as #1 Test in the screenshot. The "lighter text" is the same color as user2. It looks better to highlight something, but when it's used for all the text it looks too bright imo

Lighter Text

[lunny]

If you can move the related js codes on a spereate js file, that will be perfect!!!

[silverwind]

@jolheiser much better, thanks. I'd maybe go a shade darker even on the border, but no biggie.

@lunny good idea. I'd suggest moving the code to web_src/js/features/contextPopups.js and then import it on index.js. It could look similar to this:

export function initContextPopups() {
  const refIssues = $('.ref-issue');
  if (!refIssues.length) return;

  // your code here
}

and load via

import { initContextPopups } from './features/contextPopups.js';

[6543]

nice PS: for js stuff i point to silverwind ....

[codecov-io]

Codecov Report

Merging #9822 into master will decrease coverage by 0.03%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master    #9822      +/-   ##
==========================================
- Coverage   42.27%   42.24%   -0.04%     
==========================================
  Files         605      605              
  Lines       79251    79262      +11     
==========================================
- Hits        33505    33484      -21     
- Misses      41616    41644      +28     
- Partials     4130     4134       +4

Impacted Files	Coverage Δ
modules/auth/auth_form.go	100% <ø> (ø)	⬆️
modules/auth/ldap/ldap.go	54.4% <ø> (ø)	⬆️
models/user.go	50.16% <0%> (-0.3%)	⬇️
cmd/admin_auth_ldap.go	79.32% <0%> (-1.36%)	⬇️
routers/admin/auths.go	30.95% <100%> (+0.23%)	⬆️
services/pull/patch.go	62.89% <0%> (-6.92%)	⬇️
services/pull/temp_repo.go	31.62% <0%> (-2.57%)	⬇️
models/unit.go	37.03% <0%> (-2.47%)	⬇️
routers/repo/view.go	38.59% <0%> (-0.88%)	⬇️
models/repo.go	47.02% <0%> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605e23...c8c7b3d. Read the comment docs.

[jolheiser]

@silverwind Done. Had to do it slightly different to avoid being yelled at by the linter.

[mooror]

Just came across this new feature in V12. Really polishes up the interface. Great work @jolheiser (and company ;) )