-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically compile the binaries #985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
added
topic/deployment
type/enhancement
An improvement of existing functionality
labels
Feb 20, 2017
build failed |
tboerger
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 20, 2017
The static flags won't work for the darwin target. |
As we can not compile darwin binaries with static flags I have split the build process into different make tasks. Now we get static linked binaries especially for linux so that it also can run on older versions of CenOS and so on. Signed-off-by: Thomas Boerger <thomas@webhippie.de>
|
trusted LGTM |
tboerger
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 7, 2017
Trusted LGTM |
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 7, 2017
fix #551 |
This was referenced Mar 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/deployment
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To also provide static binaries I have integrated 3 different flavorsfor now. We got so far static, tidb and sqlite. I think the naming is
quite obvious.
Now we got really static compiled binaries that should also work on older linux distributions.
Signed-off-by: Thomas Boerger thomas@webhippie.de